@alexcjohnson I agree that the if six.PY2 syntax is nicer. I don't have read access to https://github.com/plotly/dash-component-system but I guess the diff looks like 2ec84b7 (note: edited commit id after force-pushing on this branch; hope it's okay).

Ah, of course, now pylint errors as it parses module names which are not available in Python 2.7 and vice versa. I'm curious to know how @T4rk1n handled this: via pylint config?

Oh that must be why he used getattr - ugh, I’d rather just silence that error (ideally only on that line)

I used

@T4rk1n Ok. I'm surprised I'm getting this:

since

I'm also curious because I'm not able to run pylint on this file locally: I'm getting error

RuntimeError: generator raised StopIteration
************* Module dash.development.base_component
F:  1, 0: <class 'RuntimeError'>: generator raised StopIteration (astroid-error)

In the end, I silenced these pylint errors at the block level, because I noticed this was done throughout the file.
@alexcjohnson may I merge? Happy to rebase if five commits seem too much for such a small change.

@mkcor I hadn't noticed this before, but @T4rk1n's comment points to our util function patch_collections_abc, which is already used in this module as:

So rather than duplicating, you could just use it again:

MutableSequence = patch_collections_abc('MutableSequence')

@T4rk1n OK I understand what you did, but would you agree it's nicer to avoid getattr if you're just passing in a constant, and simply silence the linter error with a comment? (yes, block-level is fine, I just didn't want it silenced globally in the rc file)

would you agree it's nicer to avoid getattr if you're just passing in a constant, and simply silence the linter error with a comment?

Yes, avoid if you want auto-completion and more clarity. What I wanted to avoid was the exception based solution.

@alexcjohnson oh, yes, sorry, somehow I didn't read @T4rk1n's comment carefully either!